Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

[Generator] [Model] added high unit test coverage for Generator\Model co... #223

Merged
merged 1 commit into from

4 participants

Hugo Hamon Don't Add Me To Your Organization a.k.a The Travis Bot Francois Zaninotto William Durand
Hugo Hamon
Collaborator

...mponent. Made some refactoring and micro optimizations. Fixed some coding conventions violations. Fix PHPDoc.

Hugo Hamon hhamon [Generator] [Model] added high unit test coverage for Generator\Model…
… component. Made some refactoring and micro optimizations. Fixed some coding conventions violations. Fix PHPDoc.
268f44d
Don't Add Me To Your Organization a.k.a The Travis Bot

This pull request passes (merged 268f44d into 428dfdd).

Hugo Hamon
Collaborator

Good to go!

William Durand willdurand merged commit a570a62 into from
William Durand
Owner

Awesome! \o/

Hugo Hamon
Collaborator

:)

Hugo Hamon
Collaborator

yep I saw that... That's weird because Travis says it's ok and on my machine I have the same result as Travis.

I'm digging into it.

Hugo Hamon
Collaborator

@willdurand is it possible to force a new Jenkins run for this commit?

Hugo Hamon
Collaborator

I can't see why it fails. My opinion is that the PHPUnit version running on the Jenkins server is outdated. It's PHPUnit 3.6.3... Can you upgrade PHPUnit to the latest and run the build once again please?

William Durand
Owner
Hugo Hamon
Collaborator

This is very strange that it works with Travis and my configuration (Sismo), both are on PHPUnit 3.6.10.

This is the main difference with your Jenkins installation. I can eventually try to run the test suite on a Jenkins instance on my machine with a PHPUnit 3.6.10 and then test it against a PHPUnit 3.6.3. The two broken tests that are both failing on a mock expectation. I assume that it's a bug in PHPUnit 3.6.3 with the mocking API.

Anyway I will download a PHPUnit 3.6.3 and run the test suite against it. I will let you know asap.

Hugo Hamon
Collaborator

So, running PHPUnit 3.6.3 on my machine does not fail... What's the PHP version of the Jenkins server?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on May 18, 2012
  1. Hugo Hamon

    [Generator] [Model] added high unit test coverage for Generator\Model…

    hhamon authored
    … component. Made some refactoring and micro optimizations. Fixed some coding conventions violations. Fix PHPDoc.
Something went wrong with that request. Please try again.