Fix SQLitePlateform again #279

Merged
merged 1 commit into from Jul 30, 2012

3 participants

@willdurand
Propel member

Reverted my changes, fix generated SQL only if it makes sense.

/cc @fzaninotto

@travisbot

This pull request passes (merged a948f3c8 into c4eb8ba).

@fzaninotto
Propel member

I don't get it, I thought the problem appeared when you have multiuple primary keys? Your code doesn't test that.

@fzaninotto
Propel member

Gotcha!

Then I'm all for the fix!

@willdurand
Propel member

I don't like it actually; if you missed the point, this is probably because the method is not explicit enough (object calisthenics).

I will move the condition to this method. It will be safer.

@willdurand willdurand merged commit c991a7a into propelorm:master Jul 30, 2012
@travisbot

This pull request passes (merged c19bfc6 into eaeca74).

@willdurand
Propel member
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment