Move Om to ActiveRecord #288

Merged
merged 3 commits into from Jul 30, 2012

Projects

None yet

4 participants

@willdurand
Member

No description provided.

@travisbot

This pull request passes (merged cbb7e9b into cb24f84).

@jaugustin jaugustin commented on an outdated diff Jul 30, 2012
...tedSet/NestedSetBehaviorObjectBuilderModifierTest.php
@@ -22,7 +22,7 @@
use Propel\Runtime\Collection\ObjectCollection;
use Propel\Runtime\Exception\PropelException;
use Propel\Runtime\Query\Criteria;
-use Propel\Runtime\Om\NestedSetRecursiveIterator;
+use Propel\Runtime\ActiveRecord\NestedSetRecursiveIterator;
@jaugustin
jaugustin Jul 30, 2012 Member

alphabetical order should be apply ?

@fzaninotto
Member

How about Builder\Om?

@willdurand
Member

It will be needed as well. But Om in the generator is about all generated
classes, not just ActiveRecord ones.

2012/7/30 Francois Zaninotto <
reply@reply.github.com

How about Builder\Om?


Reply to this email directly or view it on GitHub:
#288 (comment)

@fzaninotto
Member

So Generator\Builder\Om will become... Generator\Builder\Class?

@willdurand
Member

Or better, we split builders.

2012/7/30 Francois Zaninotto <
reply@reply.github.com

So Generator\Builder\Om will become... Generator\Builder\Class?


Reply to this email directly or view it on GitHub:
#288 (comment)

@fzaninotto
Member

Not sure I understand you

@willdurand
Member

I also moved Query to ActiveQuery, what do you think?

I did that because I think it's better for everyone to understand the two distinct APIs.

@willdurand
Member

In the generator, we could have:

  • Builders\ActiveRecord
  • Builders\ActiveQuery
@travisbot

This pull request passes (merged 2596d09 into cb24f84).

@fzaninotto
Member

ah ok. I'm fine with that. But shouldn't we first remove the Peer stuff?

@willdurand
Member

Yep, that's why I didn't rename the generator part yet.

@willdurand willdurand merged commit 901cc87 into propelorm:master Jul 30, 2012

1 check passed

default
Details
@willdurand
Member

Tadam!

@jeremyFreeAgent jeremyFreeAgent pushed a commit to jeremyFreeAgent/Propel2 that referenced this pull request Sep 10, 2012
@K-Phoen K-Phoen Fix: port PR #288 from Propel a9a8181
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment