Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

[Propel] [Generator] minor fixes in SchemaReader and QuickBuilder classe... #304

Merged
merged 1 commit into from Oct 4, 2012

Conversation

Projects
None yet
3 participants
Member

hhamon commented Sep 9, 2012

...s.

Owner

willdurand commented Sep 10, 2012

mmh it seems like our travis setup is broken.

Member

hhamon commented Sep 10, 2012

Yes this is due to the new syntax in the .travis.yml file. The create database test statement fails because the test already exists. We should have a drop table if exists statement before to ensure the DB is recreated from scratch.

Contributor

jeremyFreeAgent commented Sep 10, 2012

True, I saw that yesterday, the database already exists.

Contributor

jeremyFreeAgent commented Sep 10, 2012

By the way, why sometimes it's create database et et sometimes it's create schema ?

Owner

willdurand commented Sep 10, 2012

I fixed Propel 1.6 but not Propel2. Actually, we need to fix both travis-ci
and the test suite.
It creates schemas and databases to test different things.

On Mon, Sep 10, 2012 at 2:21 PM, Jérémy Romey notifications@github.comwrote:

By the way, why sometimes it's @create https://github.com/createdatabase@et et sometimes it's
@create https://github.com/create schema@ ?


Reply to this email directly or view it on GitHubhttps://github.com/propelorm/Propel2/pull/304#issuecomment-8421646.

Contributor

jeremyFreeAgent commented Sep 10, 2012

Yes but the keyword database equals schema in MySQL !

Owner

willdurand commented Sep 10, 2012

???

On Mon, Sep 10, 2012 at 2:31 PM, Jérémy Romey notifications@github.comwrote:

Yes but the keyword database equals schema in MySQL !


Reply to this email directly or view it on GitHubhttps://github.com/propelorm/Propel2/pull/304#issuecomment-8421855.

Contributor

jeremyFreeAgent commented Sep 10, 2012

http://dev.mysql.com/doc/refman/5.6/en/create-database.html

CREATE SCHEMA is a synonym for CREATE DATABASE.

Owner

willdurand commented Sep 10, 2012

In MySQL yes, but it's different with other RDBMS

On Mon, Sep 10, 2012 at 2:46 PM, Jérémy Romey notifications@github.comwrote:

http://dev.mysql.com/doc/refman/5.6/en/create-database.html

CREATE SCHEMA is a synonym for CREATE DATABASE.


Reply to this email directly or view it on GitHubhttps://github.com/propelorm/Propel2/pull/304#issuecomment-8422219.

Contributor

jeremyFreeAgent commented Sep 10, 2012

True, I was asking because the travis config is based on MySQL. I was just wondering... :D

Contributor

jeremyFreeAgent commented Oct 3, 2012

@hhamon you need to push again in order to run again travis build test :(

Member

hhamon commented Oct 3, 2012

Rebased on top of master

Contributor

jeremyFreeAgent commented Oct 3, 2012

Yeah ! Good to merge !

@willdurand willdurand added a commit that referenced this pull request Oct 4, 2012

@willdurand willdurand Merge pull request #304 from hhamon/generator_fixes
[Propel] [Generator] minor fixes in SchemaReader and QuickBuilder classe...
bc1ea20

@willdurand willdurand merged commit bc1ea20 into propelorm:master Oct 4, 2012

1 check passed

default The Travis build passed
Details
Owner

willdurand commented Oct 4, 2012

Thank you, and then again, sorry for the delay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment