Missing parent Query class #538

Merged
merged 1 commit into from Apr 1, 2014

Conversation

Projects
None yet
4 participants
Contributor

gharlan commented Feb 23, 2014

After building the model classes for the bookstore example I get the two classed DistributionOnlineQuery and DistributionVirtualStoreQuery. Both extends DistributionStoreQuery, but this class is missing.

Owner

marcj commented Feb 10, 2014

Are you sure - do you have more information? I have this class and it works here.

Contributor

gharlan commented Feb 10, 2014

The stub class is generated, but the base class is missing.

https://github.com/propelorm/Propel2/blob/master/src/Propel/Generator/Manager/ModelManager.php#L96
getAncestor() returns null for DistributionStore..

Member

staabm commented Feb 10, 2014

@gharlan could you post a reduced repro-testcase?

Contributor

gharlan commented Feb 10, 2014

Try this:

git clone https://github.com/propelorm/Propel2.git propel
cd propel
composer install
cp tests/Fixtures/bookstore/schema.xml schema.xml
./bin/propel build
[ -f generated-classes/Propel/Tests/Bookstore/Base/DistributionStoreQuery.php ] && echo "Found" || echo "Not found"
Contributor

gharlan commented Feb 23, 2014

added a failing test to show the problem..

Contributor

gharlan commented Mar 9, 2014

should be fixed now..

Owner

willdurand commented Mar 16, 2014

can anyone else confirm?

@willdurand willdurand added this to the alpha-3 milestone Mar 16, 2014

Contributor

gharlan commented Mar 27, 2014

nobody?

Owner

marcj commented Apr 1, 2014

Yes, was able to confirm it. Your PR does fix it, thanks!

marcj added a commit that referenced this pull request Apr 1, 2014

@marcj marcj merged commit de36be2 into propelorm:master Apr 1, 2014

1 check passed

default The Travis CI build passed
Details

@gharlan gharlan deleted the gharlan:missing-base-query-classes branch Apr 1, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment