sql-insert command should use configuration file #550

Closed
wants to merge 1 commit into
from

Projects

None yet

2 participants

@nekufa
Contributor
nekufa commented Feb 24, 2014

Looks like it was designed the buildtime-conf is used by all console commands (AbstractCommand@getGeneratorConfig).
SqlInsert command overrides input-dir property (as sql source location).
So getGeneratorConfig method looks for database configuration in generated-sql folder.

I've changed input-dir property to sql-dir property, so sql scripts would be look up there, and connection settings are looking in default input-dir (as other console commands).

@nekufa nekufa sql-insert command should use configuration file
Looks like it was designed the buildtime-conf is used by all console commands (AbstractCommand@getGeneratorConfig).
SqlInsert command overrides input-dir property (as sql source location).
So getGeneratorConfig method looks for database configuration in generated-sql folder.

I've changed input-dir property to sql-dir property, so sql scripts would be look up there, and connection settings are looking in default input-dir (as other console commands).
9c1f370
@marcj
Member
marcj commented Mar 9, 2014

Well, you would need to update TestPrepareCommand as well or the test suite won't be green.

@marcj
Member
marcj commented Apr 11, 2014

ping @nekufa

@marcj marcj added the Enhancement label Apr 11, 2014
@nekufa
Contributor
nekufa commented Apr 11, 2014

@marcj sorry, but i don't understand how ti give repository fork back.
i suddenly removed it and can't edit this pull request anymore :( can you help me?

@nekufa
Contributor
nekufa commented Apr 11, 2014

maybe i can create new fork, make changes, complete tests and send new pull request?

@marcj
Member
marcj commented Apr 11, 2014

Sure, just send a new one :)

@marcj marcj closed this Apr 11, 2014
@nekufa
Contributor
nekufa commented Apr 11, 2014

Okey, thanks! :)
Unit tests not run out of the box - maybe there are developer notes somewhere?

@marcj
Member
marcj commented Apr 11, 2014

Take a look here please: http://propelorm.org/contribute.html

@nekufa
Contributor
nekufa commented Apr 11, 2014

thanks, that is what i need!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment