Fix getting option value from configuration #570

Merged
merged 1 commit into from Mar 17, 2014

Conversation

Projects
None yet
3 participants

drodil commented Mar 10, 2014

Configuration tries to read ['value'] from an array but it throws a PHP Warning: Illegal string offset 'value'.

Configuration file containing

<options>
    <option id="PDO::MYSQL_ATTR_INIT_COMMAND">SET NAMES utf8</option>
</options>

Generates the following PHP configuration file:

'options' =>
  array (
    'PDO::MYSQL_ATTR_INIT_COMMAND' => 'SET NAMES utf8',
  ),
Owner

willdurand commented Mar 16, 2014

@willdurand willdurand added the Bug label Mar 16, 2014

@willdurand willdurand added this to the alpha-3 milestone Mar 16, 2014

Member

cristianoc72 commented Mar 17, 2014

It's correct. And it'll not change it, while refactoring config. Imho it can be merged.

willdurand added a commit that referenced this pull request Mar 17, 2014

Merge pull request #570 from drodil/master
Fix getting option value from configuration

@willdurand willdurand merged commit 28300af into propelorm:master Mar 17, 2014

1 check passed

default The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment