Skip to content

return type hint for endUse() #571

Merged
merged 1 commit into from Mar 16, 2014

2 participants

@gharlan
gharlan commented Mar 10, 2014

The endUse() method is returning a QueryClass of a related table. So we can not use @return $this here (see #560). At the moment the return type of endUse() is Criteria. With this PR every Query base class gets a @method tag for endUse with return type of all possible (related) classes. So autocompletion and type inference in IDE is possible.

@gharlan
gharlan commented Mar 11, 2014

(added description)

@willdurand willdurand merged commit f03800e into propelorm:master Mar 16, 2014

1 check passed

Details default The Travis CI build passed
@gharlan gharlan deleted the gharlan:endUse-return-type branch Mar 16, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.