transaction: always return the result of the callable #576

Merged
merged 1 commit into from Mar 16, 2014

Conversation

Projects
None yet
3 participants
Contributor

gharlan commented Mar 12, 2014

Member

staabm commented Mar 12, 2014

since the initial implmentation was inspired by doctrine, I asked there and waiting for response before merging this

doctrine/doctrine2@877ba9b#commitcomment-5644729

Member

staabm commented Mar 12, 2014

ok, they also consider it a bug but cannot fix it for BC reasons.

looks good to me.

willdurand added a commit that referenced this pull request Mar 16, 2014

Merge pull request #576 from gharlan/transaction-return-value
transaction: always return the result of the callable

@willdurand willdurand merged commit 0f44ecc into propelorm:master Mar 16, 2014

1 check passed

default The Travis CI build passed
Details

@gharlan gharlan deleted the gharlan:transaction-return-value branch Mar 16, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment