Fixed errors in `OracleAdapterTest`. #61

Merged
merged 1 commit into from Nov 21, 2011

2 participants

@fzaninotto
Propel member

Because of a change in PdoAdapter, the signature of OrcaleAdapter::initConnection() wasn't compatible anymore with that of its parent.

Errors in unit tests would occur:

1) Propel\Tests\Runtime\Adapter\Pdo\OracleAdapterTest::testApplyLimitSimple
Declaration of Propel\Runtime\Adapter\Pdo\OracleAdapter::initConnection() should be compatible with that of Propel\Runtime\Adapter\Pdo\PdoAdapter::initConnection()

Propel2/src/Propel/Runtime/Adapter/Pdo/OracleAdapter.php:35
Propel2/vendor/Symfony/Component/ClassLoader/UniversalClassLoader.php:229
Propel/Tests/Runtime/Adapter/Pdo/OracleAdapterTest.php:33

These are now fixed.

@fzaninotto fzaninotto Fixed errors in `OracleAdapterTest`.
Because of a change in `PdoAdapter`, the signature of `OrcaleAdapter::initConnection()` wasn't compatible anymore with that of its parent.

Errors in unit tests would occur:

1) Propel\Tests\Runtime\Adapter\Pdo\OracleAdapterTest::testApplyLimitSimple
Declaration of Propel\Runtime\Adapter\Pdo\OracleAdapter::initConnection() should be compatible with that of Propel\Runtime\Adapter\Pdo\PdoAdapter::initConnection()

Propel2/src/Propel/Runtime/Adapter/Pdo/OracleAdapter.php:35
Propel2/vendor/Symfony/Component/ClassLoader/UniversalClassLoader.php:229
Propel/Tests/Runtime/Adapter/Pdo/OracleAdapterTest.php:33

These are now fixed.
a368819
@willdurand willdurand merged commit 4db98f1 into propelorm:master Nov 21, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment