Fixed ActiveRecordObject->save() returning wrong results, Fixed concrete inheritence save-loop-bug

[tals56]

I have added code to ObjectBuilder.php which fixes returning wrong results when performing updates,
and now throwing an exception when trying to update non-existant objects.

Also, 2 bugs in concrete inheritence were fixed:
1.getSyncParent() - now the inherited object stores its parent, and returns the same one when the parent object has been created \ retrieved.

2.Loop-saving when saving parent - a quite massive bug causing 2 parent objects to be saved, due to loop-saving in inherited objects, and extra non-required SQL statements to be performed.

[tals56]

Hello,
I'm quite new to GitHub ( and new to Git actually )
so please check whether I made any mistakes when committing code.

Thank you.

[tals56]

If someone may try to help:
I don't understand why the tests fail when looking for \Propel\Tests\Bookstore\Behavior\ConcreteArticle.

Thank you.

[mpscholten]

The ConcreteArticle class will be created in the constructor of the test. So you cannot extend the ConcreteArticle class before the Test has started.

You would need to wait until the setUp method was called, to create your helper class. Try to move the helper class into another file and then include the file after the QuickBuilder::buildSchema($schema); is called.

Maybe it's also possible to replace your helper class with php unit mocks. This should also solve the failing test.

[marcj]

Feel free to ask us more question to understand the test suite better and get it green.

[dereuromark]

Almost 6 years stale, closing then.