Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Removed validation. Fixes #94 #96

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
Owner

willdurand commented Dec 16, 2011

See #94, to be discussed.

I would like to see the impact on the code.

Owner

willdurand commented Dec 20, 2011

@fzaninotto @jaugustin mergeable ? I'd like to slim Propel2 and to rely on existing and strong implementations if needed.

Member

fzaninotto commented Dec 21, 2011

Well, I don't agree, I already said why. Now if you want to go on and disappoint Propel1 users by removing features, go ahead.

If you want to remove the current validation code, replace it by something better.

Owner

willdurand commented Dec 21, 2011

I'm pretty sure we'll regret that later. Remember, you didn't put your head in this part.

@willdurand willdurand closed this Dec 21, 2011

@willdurand willdurand reopened this Dec 23, 2011

Owner

willdurand commented Mar 26, 2012

I'm closing this one as @cristianoc72's PR is almost complete.

@willdurand willdurand closed this Mar 26, 2012

@hhamon hhamon pushed a commit to hhamon/Propel2 that referenced this pull request May 15, 2012

@fzaninotto fzaninotto [generator] Introducing buildtime schema validation.
All schema validation cannot be done in XSD. For more complex validations,
some PHP processing is required. This patch moves validation logic into a
simple and independent validation service. It processes the whole schema
in order to output all error messages at once.
Closes #3. Closes #96.
8663103
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment