Run PHP-CS PSR2 #168

Merged
merged 1 commit into from Jul 19, 2012

Projects

None yet

6 participants

Adel-E commented Jul 18, 2012

No description provided.

This pull request passes (merged 10e64129 into 102c7ac).

Member
havvg commented Jul 19, 2012

Could you also fix the phpDoc for the $request parameter and squash the commits afterwards? - Thank you.

This pull request passes (merged 1976b9cd into 102c7ac).

@jaugustin jaugustin commented on the diff Jul 19, 2012
Request/ParamConverter/PropelParamConverter.php
@@ -178,6 +199,7 @@ protected function findOneBy($classQuery, Request $request)
* Init the query class with optional joinWith
*
* @param string $classQuery
+ *
jaugustin
jaugustin Jul 19, 2012 Member

good ;) but also missing the @return phpdoc ;)

Adel-E
Adel-E Jul 19, 2012

The return is an instance of ModelCriteria?

This pull request passes (merged 55f05807 into 102c7ac).

Owner

Hi. Could you run the PHP-CS-Fixer tool on the whole project?

Adel-E commented Jul 19, 2012

Ok :)

Adel-E commented Jul 19, 2012

@willdurand do you want me to squash the commits, or i leave them like this?

This pull request passes (merged 76b49182 into 102c7ac).

@willdurand willdurand and 2 others commented on an outdated diff Jul 19, 2012
Resources/skeleton/FormType.php
@@ -5,7 +5,7 @@
use Symfony\Component\Form\AbstractType;
use Symfony\Component\Form\FormBuilderInterface;
-class ##CLASS## extends AbstractType

This pull request passes (merged e2eb3acb into 102c7ac).

This pull request passes (merged 4219e70 into 102c7ac).

@willdurand willdurand merged commit b5e58ed into propelorm:1.1 Jul 19, 2012
Owner

Perfect, thanks!

Adel-E commented Jul 19, 2012

😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment