Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Fix: using the "with" option in ParamConverters triggered a notice #186

Merged
merged 1 commit into from

2 participants

@K-Phoen

The following notice was triggered:

Runtime Notice: Only variables should be passed by reference in
/home/vagrant/www/project/vendor/propel/propel-bundle/Propel/PropelBundle/Request/ParamConverter/PropelParamConverter.php
line 193
@K-Phoen K-Phoen Fix: using the "with" option in ParamConverters triggered a notice
The following notice was triggered:

  Runtime Notice: Only variables should be passed by reference in
  /home/vagrant/www/project/vendor/propel/propel-bundle/Propel/PropelBundle/Request/ParamConverter/PropelParamConverter.php
  line 193
bc15b92
@willdurand willdurand merged commit f4c290f into propelorm:1.1
@willdurand
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Oct 31, 2012
  1. @K-Phoen

    Fix: using the "with" option in ParamConverters triggered a notice

    K-Phoen authored
    The following notice was triggered:
    
      Runtime Notice: Only variables should be passed by reference in
      /home/vagrant/www/project/vendor/propel/propel-bundle/Propel/PropelBundle/Request/ParamConverter/PropelParamConverter.php
      line 193
This page is out of date. Refresh to see the latest.
Showing with 2 additions and 1 deletion.
  1. +2 −1  Request/ParamConverter/PropelParamConverter.php
View
3  Request/ParamConverter/PropelParamConverter.php
@@ -190,7 +190,8 @@ protected function findOneBy($classQuery, Request $request)
if (!$this->hasWith) {
return $query->findOne();
} else {
- return reset($query->find());
+ $results = $query->find();
+ return reset($results);
}
}
Something went wrong with that request. Please try again.