Fix inverted command verbosity for PropelBundle 1.4/1.5/1.6 #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
$bufferPhingOutput is initially set to Symfony's kernel.debug parameter. However, the conditional for checking the buffer works the other way round: If buffering is enabled, the buffer is discarded, otherwise it is output. This commit fixes that issue. Now if $bufferPhingOutput is true, the detailed output of the command is displayed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the 1.x branches of PropelBundle, the verbosity is apparently inverted to the expected behaviour.
$bufferPhingOutput is initially set to Symfony's kernel.debug parameter.
However, the conditional for checking the buffer works the other way round:
If buffering is enabled, the buffer is discarded, otherwise it is output.
This commit fixes that issue. Now if $bufferPhingOutput is true,
the detailed output of the command is displayed.