Symfony 4.0 updates #483
Merged
Symfony 4.0 updates #483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#SymfonyConHackday2017
* Updated format of object dumping as deprecated tags using colon symfony/yaml 38d3087
…undle commands * Updated two services to public
* macroprog/4.0: Upd: Removing old SF version + PHPUnit correction Upd: PHP 5 not supported anymore by PHPUnit Upd: Travis configuration PropelBundle for Symfony 4 Upd: Configure visibility of services for SF4 Upd: Add Symfony 4 Compatibility # Conflicts: # DataCollector/PropelDataCollector.php # DataFixtures/Dumper/YamlDataDumper.php # Tests/Model/EntryTest.php # Tests/Model/SecurityIdentityTest.php # Tests/Security/Acl/MutableAclProviderTest.php # composer.json
* reverted unnecessary changes to abstract command and schemal locator * Added fixtures for schema testing.
* reverted unnecessary changes to abstract command and schemal locator * Added fixtures for schema testing.
|
When this PR will be merge? |
|
Hi @cristianoc72 can you merge this PR? |
|
@eugenekurasov sorry, I can't: I haven't push rights on this repo |
|
Will this remove Symfony 2.8-3.x support? If so, we need to merge this in a new 4.x branch. |
|
It looks like @cristianoc72 confirmed working in 3.4, and I have confirmed this will break in 2.8. Shall I update the readme to reflect working versions? Looks like it would make sense to create it's own branch until I can figure out backwards compatibility |
|
Yes, please update the readme accordingly. I changed the target branch to 4.0 |
|
@kingchills can you update readme? |
* Updated readme to reflect symfony version support
|
@kingchills thank you |
|
Thanks! |
kingchills
pushed a commit
to kingchills/PropelBundle
that referenced
this pull request
Feb 19, 2018
* upstream/4.0: use ChildDefinition instead of DefinitionDecorator (propelorm#485) Symfony 4.0 updates (propelorm#483)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for Symfony 4.0. Updated unit tests to remove deprecated functions, and match current object serialization strings for YamlDumper