Skip to content
This repository

fix admin gen m2m issue tableMap not found #139 #142

Merged
merged 1 commit into from about 2 years ago

4 participants

Jérémie Augustin Don't Add Me To Your Organization a.k.a The Travis Bot rozwell William Durand
Jérémie Augustin
Collaborator

hi,

This fix #139

I will add tests to prevent regression.

@rozwell could you test it ?

Don't Add Me To Your Organization a.k.a The Travis Bot

This pull request passes (merged 443f47c into c2036d0).

rozwell
Collaborator
rozwell commented

Hello, I apologize for my lack of time...

Checked, works.

Thanks ;)

Jérémie Augustin
Collaborator

No I should apologize for the BC break ;)

rozwell
Collaborator

@jaugustin no worries, happens :)

Could this one be finally merged, please?

Jérémie Augustin
Collaborator

I work on it today (add tests)

William Durand willdurand merged commit b174232 into from
William Durand
Owner

Ok merged, we'll add tests later.

William Durand
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Showing 1 unique commit by 1 author.

May 29, 2012
Jérémie Augustin jaugustin [wip] fix admin gen m2m issue tableMap not found #139 443f47c
This page is out of date. Refresh to see the latest.

Showing 1 changed file with 3 additions and 1 deletion. Show diff stats Hide diff stats

  1. +3 1 lib/generator/sfPropelGenerator.class.php
4 lib/generator/sfPropelGenerator.class.php
@@ -183,7 +183,9 @@ protected function loadMapBuilderClasses()
183 183 // and all tables related to the related table maps (for m2m relations)
184 184 foreach ($this->tableMap->getRelations() as $relation)
185 185 {
186   - $relation->getForeignTable()->getRelations();
  186 + foreach ($relation->getForeignTable()->getRelations() as $relationN) {
  187 + $relationN->getLocalTable()->getRelations();
  188 + }
187 189 }
188 190 }
189 191

Tip: You can add notes to lines in a file. Hover to the left of a line to make a note

Something went wrong with that request. Please try again.