Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fix for using platform class configured in build properties #149

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants

grray commented Jul 10, 2012

Fix related to propelorm/Propel#407 for using platform class configured in build properties

Owner

willdurand commented Jul 10, 2012

You can't change this parameter that way you will break BC..

grray commented Jul 10, 2012

How can i use my own platform class? Need to change propel to native type mapping.

Owner

willdurand commented Jul 10, 2012

You can check if the parameter in the config is present (not null), then you use it. Otherwise use the existing code.

grray commented Jul 10, 2012

But GeneratorConfig::getConfiguredPlatform seems doing the same? Or I'm wrong?

This pull request fails (merged 8cfc3a1 into 9177ece).

Owner

willdurand commented Jul 11, 2012

Well, the getPlatform() seems a bit different. And I don't want to break things in this plugin.

@willdurand willdurand closed this Dec 22, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment