automatically eval dynamically added widget's script #155

Merged
merged 2 commits into from May 13, 2013

4 participants

@ksn135

No description provided.

ksn135 added some commits Aug 27, 2012
@ksn135 ksn135 Update lib/widget/sfWidgetFormSchemaOptional.class.php
added execution of DOM-ready init-scripts for all dynamically added widgets via embedRelation such as sfWidgetFormPropelJQueryAutocompleter or sfWidgetFormDateJQueryUI
eb53efc
@ksn135 ksn135 automatically eval dynamically added widget's script 027c5e6
@travisbot

This pull request passes (merged 027c5e6 into 67a3936).

@willdurand
Propel member

Mmh, @themouette @rozwell could you review this PR? thanks

@rozwell

@willdurand ok, will check it.

@willdurand
Propel member
@willdurand
Propel member

eval is evil.

@willdurand willdurand closed this Dec 22, 2012
@rozwell

Damn it, I forgot about this one...
AFAIR I had this solved in a good way so if I find it, I'll create a PR.

@willdurand
Propel member
@rozwell

I just ran into this issue and couldn't find the code I was talking about - it was from the time I was playing a lot with nested forms and there isn't left much of it.
To make this work in a "good way" IMHO we should take out the whole js from a widget, wrap it with a js function and place in a parent form for later execution...

I vote to merge it with a FIXME/TODO note - it's better to have a feature working instead of not working at all.

@rozwell rozwell reopened this May 13, 2013
@rozwell rozwell merged commit b5f5fe6 into propelorm:master May 13, 2013

1 check passed

Details default The Travis build passed
@rozwell rozwell added a commit that referenced this pull request May 13, 2013
@rozwell rozwell Added FIXME for #155 cec516d
@rozwell

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment