Reify to list #3
Merged
+8
−7
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Modularize the parse macro to use another macro that reifies composite languages type into a list of string or languages.
It could be useful for other purposes that use the composite type, e.g. create a new I18n with just the new type, not narrowing the type but extracting those elements.
It includes the challenge of how to turn the
List[String]return intoList[_ <: L]I couldn't see how to prove that as the matching is for theStringConstant, and that is not parameterised so we lose that proof that is guaranteed by the decomposition. A cast should be needed probably.