Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarify names of add and delete subcommands #55

Closed
rberenguel opened this issue Dec 15, 2018 · 9 comments
Closed

clarify names of add and delete subcommands #55

rberenguel opened this issue Dec 15, 2018 · 9 comments

Comments

@rberenguel
Copy link

@rberenguel rberenguel commented Dec 15, 2018

Add/remove sounds more natural than add/delete, but I'm not sure if it is just to me. If I'm not the only one, I guess having remove to alias internally to delete would be helpful

@propensive
Copy link
Owner

@propensive propensive commented Dec 20, 2018

I'm against having multiple alternative names for the same command (even if one is hidden), but I'm not against changing delete to remove or del.

But first, what do other people thing? Does anyone prefer delete to remove (i.e. the current behavior)?

@propensive propensive changed the title Make remove an (internal) alias of delete rename delete commands to remove Dec 20, 2018
@leifwickland
Copy link

@leifwickland leifwickland commented Jan 11, 2019

I agree that remove is the natural complement to add, analogous to create/delete. "Add" and "remove" suggest membership.

However, reading the docs, it appears that perhaps you don't want membership.

[add] may be used to create new projects and modules respectively.

I'm tempted to offer a third opinion and say that it is add which should be changed to create and that delete is just fine. :-)

(Am I doing bikeshedding right?)

@propensive
Copy link
Owner

@propensive propensive commented Jan 11, 2019

Yes, that's totally the correct way to do it. I hope some other bikeshedding experts will add (or create) some more suggestions. Anyway, I also wondered whether create would have been a better choice, so it's not a bad suggestion.

@propensive propensive changed the title rename delete commands to remove clarify names of add and delete subcommands Jan 11, 2019
@ianp
Copy link

@ianp ianp commented Jan 11, 2019

remove makes more sense to me, although personally I'd go with summon and banish 😈

@jeffrey-aguilera
Copy link

@jeffrey-aguilera jeffrey-aguilera commented Jan 11, 2019

unadd

@gabro
Copy link

@gabro gabro commented Jan 11, 2019

Embrace the bash way and use dda?

@tobias-johansson
Copy link

@tobias-johansson tobias-johansson commented Jan 11, 2019

add/drop?

@marklister
Copy link

@marklister marklister commented Jan 12, 2019

So in your talk you said something like "git like workflow"

Git's equivalent is probably rm

@propensive
Copy link
Owner

@propensive propensive commented Jan 12, 2019

Ok, I'm going with add/remove. I'm not going to use rm, because it suggests (to me, at least) working with files.

@propensive propensive closed this Jan 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
8 participants