Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @performance annotation #274

Draft
wants to merge 2 commits into
base: legacy
from
Draft

Add @performance annotation #274

wants to merge 2 commits into from

Conversation

@propensive
Copy link
Owner

@propensive propensive commented Nov 10, 2020

This introduces a new @performance annotation, which can be used on a gen method definition (the same as a @debug annotation) to trigger a performance report (provided by Probably) to be displayed once at the end of compilation. A single @performance annotation will trigger performance reporting for all derivations (by design).

This PR relies on a trick suggested by @som-snytt.

Still to do: Make Probably an optional dependency of Magnolia. It should not be required in all cases.

@propensive propensive requested a review from joroKr21 Nov 10, 2020
@propensive
Copy link
Owner Author

@propensive propensive commented Nov 10, 2020

An example of a performance report can be seen in GitHub Actions.

@joroKr21
Copy link
Collaborator

@joroKr21 joroKr21 commented Dec 1, 2020

No clue how to read fury output but this looks great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants