Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Datetime format #26
This is somewhat related to issue #24, but not quite. It doesn't give you format strings, but it makes it possible to supply a function that changes the datestrings used via config.
I haven't updated the docs or tests, as the tests failed (I ran them via rake spec) before and after). If that is a requirement for merging, please let me know.
I think you are close, I like the idea of people passing in a function that returns a specialized object, but it needs more documentation.
I'm not so sure about setting config.humanMonths.
Could you remove the typeof checks and rely on _.isFunction too?
referenced this pull request
Oct 14, 2011
The point of splitting was that being a consumer is easier if you don't have to duplicate the selection of range, and just provide the values
I did run the check deps, and json was missing, installed that and forgot to check again, will do when I have Internet again (on a weekend trip right now :)
On 14. okt. 2011, at 16:25, Jeff Larsonreply@reply.github.com wrote: