From ebc397f3eb9cfa9b2e2a275ca4f9b3b3cf1ea59c Mon Sep 17 00:00:00 2001 From: Benabdellah22 Date: Sun, 26 Oct 2025 21:34:45 +0100 Subject: [PATCH 1/2] Fix: correct joint passage reward function (issue #145) --- vmas/scenarios/joint_passage.py | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/vmas/scenarios/joint_passage.py b/vmas/scenarios/joint_passage.py index cea4268a..64d54a43 100644 --- a/vmas/scenarios/joint_passage.py +++ b/vmas/scenarios/joint_passage.py @@ -458,11 +458,10 @@ def reward(self, agent: Agent): self.world.get_distance(a, passage) <= self.min_collision_distance ] += self.collision_reward - for wall in self.walls: - self.collision_rew[ - self.world.get_distance(a, wall) - <= self.min_collision_distance - ] += self.collision_reward + for wall in self.walls: + self.collision_rew[ + self.world.get_distance(a, wall) <= self.min_collision_distance + ] += self.collision_reward # Joint collisions for p in self.passages: From 9090d258b9436e9172fa6381861244e9431c1d83 Mon Sep 17 00:00:00 2001 From: Matteo Bettini Date: Mon, 27 Oct 2025 09:21:46 +0000 Subject: [PATCH 2/2] fix --- vmas/scenarios/joint_passage_size.py | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/vmas/scenarios/joint_passage_size.py b/vmas/scenarios/joint_passage_size.py index befaf8b3..d22d8a55 100644 --- a/vmas/scenarios/joint_passage_size.py +++ b/vmas/scenarios/joint_passage_size.py @@ -1,4 +1,4 @@ -# Copyright (c) 2022-2024. +# Copyright (c) 2022-2025. # ProrokLab (https://www.proroklab.org/) # All rights reserved. import math @@ -453,11 +453,10 @@ def reward(self, agent: Agent): self.world.get_distance(a, passage) <= self.min_collision_distance ] += self.collision_reward - for wall in self.walls: - self.collision_rew[ - self.world.get_distance(a, wall) - <= self.min_collision_distance - ] += self.collision_reward + for wall in self.walls: + self.collision_rew[ + self.world.get_distance(a, wall) <= self.min_collision_distance + ] += self.collision_reward # Energy reward if self.energy_reward_coeff != 0: