New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect image path generated for sites with a `baseurl` #613

Closed
okayjeffrey opened this Issue Oct 4, 2013 · 24 comments

Comments

Projects
None yet
@okayjeffrey

okayjeffrey commented Oct 4, 2013

I am having the same issue and my last issue that was closed without resolution. (#589)

I believe all the documentation I have seen, its always on root directories not subdirectory sites.

baseurl: /ebg
relative_permalinks: false
permalink: pretty

prose:
siteurl: "http://jeffreylarrimore.com/ebg/"
media: 'img'

Issues

  • Img upload not working
  • page preview not working
  • images in the img directory not linking to properly
@BlakeTurner

This comment has been minimized.

Show comment
Hide comment
@BlakeTurner

BlakeTurner Oct 8, 2013

I'm having what may be a similar issue. The images themselves do not seem to be committing and/or adding themselves to the repo, so I'm getting a 404 when I try to access the image.

BlakeTurner commented Oct 8, 2013

I'm having what may be a similar issue. The images themselves do not seem to be committing and/or adding themselves to the repo, so I'm getting a 404 when I try to access the image.

@reyman

This comment has been minimized.

Show comment
Hide comment
@reyman

reyman Oct 10, 2013

Same error here, image upload don't work

reyman commented Oct 10, 2013

Same error here, image upload don't work

@txchen

This comment has been minimized.

Show comment
Hide comment
@txchen

txchen Oct 15, 2013

Same here, cannot upload image

txchen commented Oct 15, 2013

Same here, cannot upload image

@Jamesford

This comment has been minimized.

Show comment
Hide comment
@Jamesford

Jamesford Oct 31, 2013

Upload image works (for me anyways) if you drag and drop into the markdown text editing area, but the page will freeze. Image will be uploaded and refreshing unfreezes the page. Other than that I cannot upload images.

Jamesford commented Oct 31, 2013

Upload image works (for me anyways) if you drag and drop into the markdown text editing area, but the page will freeze. Image will be uploaded and refreshing unfreezes the page. Other than that I cannot upload images.

@shellscape

This comment has been minimized.

Show comment
Hide comment
@shellscape

shellscape Nov 17, 2013

I can confirm what @Jamesford reported.

Upon dropping an image into the dropzone, the page freezes while the image is uploaded. But the image is actually uploaded.

Using the 'select' link, no image is actually uploaded.

How is this bug still open after reported more than a month ago?

shellscape commented Nov 17, 2013

I can confirm what @Jamesford reported.

Upon dropping an image into the dropzone, the page freezes while the image is uploaded. But the image is actually uploaded.

Using the 'select' link, no image is actually uploaded.

How is this bug still open after reported more than a month ago?

@shellscape

This comment has been minimized.

Show comment
Hide comment
@shellscape

shellscape Nov 19, 2013

Don't know if bumping does anything on Github issues, but bump.

shellscape commented Nov 19, 2013

Don't know if bumping does anything on Github issues, but bump.

@okayjeffrey

This comment has been minimized.

Show comment
Hide comment
@okayjeffrey

okayjeffrey Nov 19, 2013

Hahaha how are you gonna bump an issue. The point is to take care of it not bump it.


Jeffrey

On Tue, Nov 19, 2013 at 10:01 AM, Andrew Powell notifications@github.com
wrote:

Don't know if bumping does anything on Github issues, but bump.

Reply to this email directly or view it on GitHub:
#613 (comment)

okayjeffrey commented Nov 19, 2013

Hahaha how are you gonna bump an issue. The point is to take care of it not bump it.


Jeffrey

On Tue, Nov 19, 2013 at 10:01 AM, Andrew Powell notifications@github.com
wrote:

Don't know if bumping does anything on Github issues, but bump.

Reply to this email directly or view it on GitHub:
#613 (comment)

@shellscape

This comment has been minimized.

Show comment
Hide comment
@shellscape

shellscape Nov 19, 2013

Oh just seeing if it was like the old forum days, where a bump would generate a new notice :) Not 'bump' as in dismiss. I reached out to Mike Morris on twitter a few times but haven't heard anything back. I'd be willing to contribute to a bounty just to get this fixed up.

shellscape commented Nov 19, 2013

Oh just seeing if it was like the old forum days, where a bump would generate a new notice :) Not 'bump' as in dismiss. I reached out to Mike Morris on twitter a few times but haven't heard anything back. I'd be willing to contribute to a bounty just to get this fixed up.

@mikemorris

This comment has been minimized.

Show comment
Hide comment
@mikemorris

mikemorris Nov 19, 2013

Member

@shellscape I'm aware of the issue, but haven't had much time to spend working on Prose recently. A pull request fixing this bug would be very welcome though.

Member

mikemorris commented Nov 19, 2013

@shellscape I'm aware of the issue, but haven't had much time to spend working on Prose recently. A pull request fixing this bug would be very welcome though.

@shellscape

This comment has been minimized.

Show comment
Hide comment
@shellscape

shellscape Nov 19, 2013

@mikemorris just as strapped for time here. would a bounty help on this at all?

shellscape commented Nov 19, 2013

@mikemorris just as strapped for time here. would a bounty help on this at all?

@mikemorris

This comment has been minimized.

Show comment
Hide comment
@mikemorris

mikemorris Nov 19, 2013

Member

Not really for getting me to solve it @shellscape, it's a problem of time, not money.

Member

mikemorris commented Nov 19, 2013

Not really for getting me to solve it @shellscape, it's a problem of time, not money.

@jlubawy

This comment has been minimized.

Show comment
Hide comment
@jlubawy

jlubawy Nov 19, 2013

@okayjeffrey If I understand this correctly you want the following to happen:

/img/cardplay.jpg automatically becomes http://jeffreylarrimore.com/jekyll-vs-hyde/img/cardplay.jpg in the image upload dialog, where http://jeffreylarrimore.com/jekyll-vs-hyde/ is your siteurl? You actually don't want to use baseurl since that is not used anywhere in the app (unless you put it in your templates).

The image uploading problem will take more time but I can give it a shot once this part is fixed.

jlubawy commented Nov 19, 2013

@okayjeffrey If I understand this correctly you want the following to happen:

/img/cardplay.jpg automatically becomes http://jeffreylarrimore.com/jekyll-vs-hyde/img/cardplay.jpg in the image upload dialog, where http://jeffreylarrimore.com/jekyll-vs-hyde/ is your siteurl? You actually don't want to use baseurl since that is not used anywhere in the app (unless you put it in your templates).

The image uploading problem will take more time but I can give it a shot once this part is fixed.

@okayjeffrey

This comment has been minimized.

Show comment
Hide comment
@okayjeffrey

okayjeffrey Nov 19, 2013

Correct

  • Prose is assuming that everything is root.
  • I think baseurl or siteurl would work fine... I don't even think it is far fetched to ask for the addition of the baseurl in the prose.yml.

I outlined it all here originally #589

I am looking at this from a client point of view. I know to add the proper urls, but if this is setup for someone else with limited knowledge.

Thank you very much.
@jlubawy

okayjeffrey commented Nov 19, 2013

Correct

  • Prose is assuming that everything is root.
  • I think baseurl or siteurl would work fine... I don't even think it is far fetched to ask for the addition of the baseurl in the prose.yml.

I outlined it all here originally #589

I am looking at this from a client point of view. I know to add the proper urls, but if this is setup for someone else with limited knowledge.

Thank you very much.
@jlubawy

@jlubawy

This comment has been minimized.

Show comment
Hide comment
@jlubawy

jlubawy Nov 19, 2013

@mikemorris my PR takes care of appending siteurl, I'll look into the media upload issues as I have time.

jlubawy commented Nov 19, 2013

@mikemorris my PR takes care of appending siteurl, I'll look into the media upload issues as I have time.

@shellscape

This comment has been minimized.

Show comment
Hide comment
@shellscape

shellscape Dec 2, 2013

@mikemorris @jlubawy that pull request was submitted 13 days ago. will that be examined any time soon?

(with reading "I don't have time" in responses and a PR going nearly two weeks without a look raises legitimate and sincere concerns about contributing being a waste of time vs. forking.)

shellscape commented Dec 2, 2013

@mikemorris @jlubawy that pull request was submitted 13 days ago. will that be examined any time soon?

(with reading "I don't have time" in responses and a PR going nearly two weeks without a look raises legitimate and sincere concerns about contributing being a waste of time vs. forking.)

@migurski

This comment has been minimized.

Show comment
Hide comment
@migurski

migurski Dec 11, 2013

I'm experiencing the same issue, see also #589.

migurski commented Dec 11, 2013

I'm experiencing the same issue, see also #589.

@mj12albert

This comment has been minimized.

Show comment
Hide comment
@mj12albert

mj12albert Feb 25, 2014

Upload image works (for me anyways) if you drag and drop into the markdown text editing area, but the page will freeze. Image will be uploaded and refreshing unfreezes the page. Other than that I cannot upload images.

I'm having this exact same issue – I thought uploading images was completely broken for me until I read this.

mj12albert commented Feb 25, 2014

Upload image works (for me anyways) if you drag and drop into the markdown text editing area, but the page will freeze. Image will be uploaded and refreshing unfreezes the page. Other than that I cannot upload images.

I'm having this exact same issue – I thought uploading images was completely broken for me until I read this.

@combs

This comment has been minimized.

Show comment
Hide comment
@combs

combs Mar 5, 2014

I see this error in the js console when dragging and dropping an image into the editor (which does not successfully upload it, even after a refresh) with Chrome 33 on Mac:

Uncaught TypeError: Cannot read property 'media' of undefined
prose.min.js:17
module.exports.Backbone.View.extend.upload
prose.min.js:17
(anonymous function)
prose.min.js:17
(anonymous function)
prose.min.js:15

combs commented Mar 5, 2014

I see this error in the js console when dragging and dropping an image into the editor (which does not successfully upload it, even after a refresh) with Chrome 33 on Mac:

Uncaught TypeError: Cannot read property 'media' of undefined
prose.min.js:17
module.exports.Backbone.View.extend.upload
prose.min.js:17
(anonymous function)
prose.min.js:17
(anonymous function)
prose.min.js:15

@JakeGinnivan

This comment has been minimized.

Show comment
Hide comment
@JakeGinnivan

JakeGinnivan Jun 10, 2014

Also chiming in on this, would be awesome to get image uploading working

JakeGinnivan commented Jun 10, 2014

Also chiming in on this, would be awesome to get image uploading working

@cirosantilli

This comment has been minimized.

Show comment
Hide comment
@cirosantilli

cirosantilli Jul 12, 2014

Contributor

Broken on live site for me.

Contributor

cirosantilli commented Jul 12, 2014

Broken on live site for me.

rposborne added a commit to rposborne/prose that referenced this issue Jul 30, 2014

@hdgarrood hdgarrood changed the title from Img Upload & Linking not working to Incorrect image path generated for sites with a `baseurl` Sep 5, 2014

@jpcours

This comment has been minimized.

Show comment
Hide comment
@jpcours

jpcours Oct 12, 2014

There are two possible solutions for the baseurl issue.

  1. Add {{site.baseurl}}/ to all image urls.
  2. Add to the head element of your html template.

Given that option 2 totally negates the utility of the baseurl config option, I vote for 1. Pull request in preparation.

jpcours commented Oct 12, 2014

There are two possible solutions for the baseurl issue.

  1. Add {{site.baseurl}}/ to all image urls.
  2. Add to the head element of your html template.

Given that option 2 totally negates the utility of the baseurl config option, I vote for 1. Pull request in preparation.

@benadamstyles

This comment has been minimized.

Show comment
Hide comment
@benadamstyles

benadamstyles Dec 13, 2014

Is this fixed? I'm still having the same problem. My _config.yml looks like:

baseurl: /making-of-history
url: http://leeds-ebooks.github.io

prose:
  siteurl: "http://leeds-ebooks.github.io/making-of-history"
  media: "images"

and when (or my clients) upload images it just looks like:

![es-1936.gif](/images/es-1936.gif)

which results in a 404 as the site is currently at leeds-ebooks.github.io/making-of-history. The above merged pull request should be resulting in the following, right?

![es-1936.gif]({{site.baseurl}}/images/es-1936.gif)

Am I doing something wrong?

benadamstyles commented Dec 13, 2014

Is this fixed? I'm still having the same problem. My _config.yml looks like:

baseurl: /making-of-history
url: http://leeds-ebooks.github.io

prose:
  siteurl: "http://leeds-ebooks.github.io/making-of-history"
  media: "images"

and when (or my clients) upload images it just looks like:

![es-1936.gif](/images/es-1936.gif)

which results in a 404 as the site is currently at leeds-ebooks.github.io/making-of-history. The above merged pull request should be resulting in the following, right?

![es-1936.gif]({{site.baseurl}}/images/es-1936.gif)

Am I doing something wrong?

@jpeg729

This comment has been minimized.

Show comment
Hide comment
@jpeg729

jpeg729 Dec 13, 2014

Contributor

You are not doing anything wrong. The fix has been accepted but the new version hasn't been published yet.

Contributor

jpeg729 commented Dec 13, 2014

You are not doing anything wrong. The fix has been accepted but the new version hasn't been published yet.

@benadamstyles

This comment has been minimized.

Show comment
Hide comment
@benadamstyles

benadamstyles Dec 13, 2014

Oh right, sorry. Thanks for explaining! Any idea what the timescale might be?

benadamstyles commented Dec 13, 2014

Oh right, sorry. Thanks for explaining! Any idea what the timescale might be?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment