Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Implement metadata image selection #1058
Possible extension functionality:
Add a _prose.yml config value to allow configuration of it metadata is set equal to the filename, eg
@Jetroid first off, sorry for my tardiness here. You've done some great work in a codebase that isn't exactly easy to work with (and is downright nasty by today's standards) so
I left some notes here. Overall I think this is on the right path but I think there are some changes I'd like to see before merging this. The main thing not mentioned here is unit tests. I wonder if breaking out some of this functionality that's now in the file, toolbar, and metadata views could be better served living in a separate, new image uploader view? I think that might help avoid some of the
Happy to hear your thoughts here and help out however I can. Thanks again.
Hi @dereklieu, sorry, I completely forgot about Prose and this pull request until Kyle posted his reminder.
I've taken another stab at this, and have broken out a lot of the functionality into a new view, AssetSelection, which renders the contents of the dialog when picking/uploading an image.
Hopefully this is more in line with the sort of thing you want for Prose.