From 336075de027e21ed1a9286c34185c9a0568053fe Mon Sep 17 00:00:00 2001 From: wulimao49 <73568161+wulimao49@users.noreply.github.com> Date: Mon, 30 Oct 2023 22:54:53 +0800 Subject: [PATCH] fix(instanced-uniforms-mesh): remove listener on dispose (#284) --- .../three-instanced-uniforms-mesh/src/InstancedUniformsMesh.js | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/three-instanced-uniforms-mesh/src/InstancedUniformsMesh.js b/packages/three-instanced-uniforms-mesh/src/InstancedUniformsMesh.js index 704e31a9..9d554c08 100644 --- a/packages/three-instanced-uniforms-mesh/src/InstancedUniformsMesh.js +++ b/packages/three-instanced-uniforms-mesh/src/InstancedUniformsMesh.js @@ -23,6 +23,7 @@ export class InstancedUniformsMesh extends InstancedMesh { derivedGeom.attributes = Object.create(baseGeom.attributes) // dispose the derived geometry when its base geometry is disposed: baseGeom.addEventListener('dispose', function onDispose () { + baseGeom.removeEventListener('dispose', onDispose) derivedGeom.dispose() }) }