denote-link: delete-line is not known to be defined

[kaushalmodi]

When I try to compile denote-link.el (Emacs 28.1.50), I get this warning

In end of data:
denote-link.el:136:12: Warning: the function ‘delete-line’ is not known to be
defined.

[protesilaos]

Oh, sorry about that @kaushalmodi. The compiler does not issue a warning about it.

How about this?

(defun denote-link-clear-stale-backlinks ()
  "Delete backlinks that no longer point to files."
  (interactive)
  (let ((default-directory (denote-directory)))
    (save-excursion
      (goto-char (point-min))
      (when (re-search-forward denote-link-backlink-heading nil t)
        (while (re-search-forward denote-link--backlink-regexp nil t)
          (unless (file-exists-p (match-string-no-properties 1))
            ;; (delete-line)
            (delete-region (point-at-bol) (point-at-bol 2))))))))

EDIT: reformat code block.

[kaushalmodi]

The compiler does not issue a warning about it.

What emacs version are you running?

I found this because I was byte-compiling each file in this repo. All files compiled clean except for denote-link.el. I was running M-x byte-compile-file in each .el buffer.

How about this?

(delete-region (point-at-bol) (point-at-bol 2))

👍 That compiles cleanly. Thanks!

[protesilaos]

What emacs version are you running?

Emacs 29.

+1 That compiles cleanly. Thanks!

Very well! Pushed the change per commit 0e65f05

[kaushalmodi]

Emacs 29.

Of course! delete-line was added only about 4 months back: https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=53da8c50fca98b5a7d0418f6030181df50af8876

[protesilaos]

Gotcha!