Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanups #193

Merged
merged 16 commits into from Nov 23, 2023
Merged

Cleanups #193

merged 16 commits into from Nov 23, 2023

Conversation

jeanphilippegg
Copy link
Contributor

No functional changes, just some refactors and removal of unnecessary code.

@jeanphilippegg
Copy link
Contributor Author

I have made additional cleanups and fixes.

Just a few general comments on programming:

  • I have made the signature parameter optional in a few internal functions (I included denote-format-file-name among those). In general, I think optional parameters are less necessary for internal functions. In this case, I think making it non optional simplifies the code.
  • I have removed some checks in multiple functions. I think it is not necessary to ensure that a paramater is of given type, particularly for internal functions. I think it makes the code harder to read.

@protesilaos
Copy link
Owner

Thank you @jeanphilippegg! I noticed you pushed some changes. Please let me know when you are done, so that I proceed to merged this.

@jeanphilippegg
Copy link
Contributor Author

I have added a few commits. It is ready to be merged!

@protesilaos protesilaos merged commit b5d3ab6 into protesilaos:main Nov 23, 2023
@protesilaos
Copy link
Owner

Merged. Thank you!

@jeanphilippegg jeanphilippegg deleted the cleanups branch November 25, 2023 15:08
@jeanphilippegg jeanphilippegg restored the cleanups branch November 25, 2023 15:09
@jeanphilippegg jeanphilippegg deleted the cleanups branch November 25, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants