ef-themes inherits faces from modus-themes #34
Comments
protesilaos
added a commit
that referenced
this issue
Dec 8, 2023
I thought I had fixed this a long time ago, but apparently I did not... Thanks to marasenna for bringing the matter to my attention in issue 34 on the GitHub mirror: <#34>.
|
From: P M ***@***.***>
Date: Thu, 7 Dec 2023 04:33:33 -0800
Ef-themes version: 1.4.0
In `ef-themes.el`:
``` elisp
`(ediff-fine-diff-Ancestor ((,c :inherit modus-themes-subtle-cyan)))
`(tab-bar ((,c :inherit modus-themes-ui-variable-pitch :background ,bg-tab-bar)))
`(tab-line ((,c :inherit modus-themes-ui-variable-pitch :background ,bg-tab-bar :height 0.95)))
`(whitespace-empty ((,c :inherit modus-themes-intense-magenta)))
`(whitespace-space-after-tab ((,c :inherit modus-themes-subtle-magenta)))
`(whitespace-space-before-tab ((,c :inherit modus-themes-subtle-cyan)))
```
I think `tab-bar` and `tab-line` should inherit from
`ef-themes-ui-variable-pitch`. However, for the rest ef-themes has no
subtle and intense faces.
Thank you! I thought I had fixed this before, but apparently I did not.
Just pushed the changes now.
…--
Protesilaos Stavrou
https://protesilaos.com
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Ef-themes version: 1.4.0
In
ef-themes.el:I think
tab-barandtab-lineshould inherit fromef-themes-ui-variable-pitch. However, for the rest ef-themes has no subtle and intense faces.The text was updated successfully, but these errors were encountered: