Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only shift unsigned values to avoid implementation-specific behavior. #508

Merged
merged 1 commit into from Jul 10, 2022

Conversation

millert
Copy link
Contributor

@millert millert commented Jun 6, 2022

This converts the arithmetic shifts to logical shifts and fixes issue #506.
It is based in part on a stackoverflow answer by John Schultz,
https://stackoverflow.com/questions/4533076/google-protocol-buffers-zigzag-encoding

This converts the arithmetic shifts to logical shifts.
It is based in part on a stackoverflow answer by John Schultz,
https://stackoverflow.com/questions/4533076/google-protocol-buffers-zigzag-encoding
@edmonds edmonds changed the base branch from master to next July 10, 2022 22:53
@edmonds edmonds added this to the 1.4.1 milestone Jul 10, 2022
@edmonds edmonds merged commit fc9b2b2 into protobuf-c:next Jul 10, 2022
AGLExport added a commit to AGLExport/meta-basic-distro that referenced this pull request Sep 28, 2022
protobuf-c/protobuf-c#508

Signed-off-by: Naoto Yamaguchi <naoto.yamaguchi@aisin.co.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants