Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: parsed options #1256

Merged
merged 12 commits into from Jul 10, 2020
Merged

feat: parsed options #1256

merged 12 commits into from Jul 10, 2020

Conversation

@eyalpost
Copy link
Contributor

@eyalpost eyalpost commented Jun 24, 2019

Properly parse option values into objects in addition to the regular option parsing.
Repeated options are preserved as well as repeated fields within nested options.
Parsed options are kept in a parsedOptions field on every level (message, field etc.)

eyalpost added 2 commits Jun 23, 2019
…option parsing. Repeated options are preserved as well as repeated fields within nested options.

Parsed options are kept in a parsedOptions field on every level (message, field etc.)
@alexander-fenster
Copy link
Contributor

@alexander-fenster alexander-fenster commented Jun 24, 2019

Thanks @eyalpost! We'll take a look soon :)

Loading

@eyalpost
Copy link
Contributor Author

@eyalpost eyalpost commented Jul 9, 2019

Any news? We'd really like to see this being merged

Loading

@Musiqua
Copy link

@Musiqua Musiqua commented Oct 16, 2019

This PR solves a problem of ours using the grps.gateway.protoc_gen_swagger_options_openapiv2_schema annotation for required fields, so we would also like to see this being merged as soon as possible.

Loading

@mavrick
Copy link

@mavrick mavrick commented Dec 7, 2019

any updates on this?

Loading

mavrick
mavrick approved these changes Dec 7, 2019
@fenos
Copy link

@fenos fenos commented Jan 22, 2020

Any Update?

Loading

ghost
ghost approved these changes Feb 7, 2020
@fenos
Copy link

@fenos fenos commented Feb 13, 2020

🎉 changes approved!! Can we please merge and cut a release 🙏

BloomRPC will benefit hugely on this

Loading

@guyisra
Copy link

@guyisra guyisra commented Mar 18, 2020

@alexander-fenster any updates on this?

Loading

@kostyay
Copy link

@kostyay kostyay commented Mar 22, 2020

any updates?

Loading

@aSapien
Copy link

@aSapien aSapien commented Jul 1, 2020

hi, is there a plan on accepting this pr?

Loading

@alexander-fenster
Copy link
Contributor

@alexander-fenster alexander-fenster commented Jul 1, 2020

I merged in the latest master and made sure the tests pass. We'll review the code changes on our next review meeting.

Loading

@alexander-fenster alexander-fenster changed the title Parsed options feat: parsed options Jul 10, 2020
@alexander-fenster alexander-fenster merged commit 7a25398 into protobufjs:master Jul 10, 2020
9 checks passed
Loading
taylorcode added a commit to taylorcode/protobuf.js that referenced this issue Oct 16, 2020
* Add option parsing tests to ensure no regressions are caused

* Properly parse option values into objects in addition to the regular option parsing. Repeated options are preserved as well as repeated fields within nested options.
Parsed options are kept in a parsedOptions field on every level (message, field etc.)

* fix: bad merge

* fix: lint

* fix: lint

* fix: lint

* fix: lint

* fix: lint

* fix: build types

Co-authored-by: Alexander Fenster <fenster@google.com>
Co-authored-by: Alexander Fenster <github@fenster.name>
@eyalpost eyalpost deleted the parsed_options branch Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

8 participants