-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: parsed options #1256
feat: parsed options #1256
Conversation
…option parsing. Repeated options are preserved as well as repeated fields within nested options. Parsed options are kept in a parsedOptions field on every level (message, field etc.)
Thanks @eyalpost! We'll take a look soon :) |
Any news? We'd really like to see this being merged |
This PR solves a problem of ours using the grps.gateway.protoc_gen_swagger_options_openapiv2_schema annotation for required fields, so we would also like to see this being merged as soon as possible. |
any updates on this? |
Any Update? |
🎉 changes approved!! Can we please merge and cut a release 🙏 BloomRPC will benefit hugely on this |
@alexander-fenster any updates on this? |
any updates? |
hi, is there a plan on accepting this pr? |
I merged in the latest master and made sure the tests pass. We'll review the code changes on our next review meeting. |
* Add option parsing tests to ensure no regressions are caused * Properly parse option values into objects in addition to the regular option parsing. Repeated options are preserved as well as repeated fields within nested options. Parsed options are kept in a parsedOptions field on every level (message, field etc.) * fix: bad merge * fix: lint * fix: lint * fix: lint * fix: lint * fix: lint * fix: build types Co-authored-by: Alexander Fenster <fenster@google.com> Co-authored-by: Alexander Fenster <github@fenster.name>
Properly parse option values into objects in addition to the regular option parsing.
Repeated options are preserved as well as repeated fields within nested options.
Parsed options are kept in a
parsedOptions
field on every level (message, field etc.)