Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Windows unc paths to be resolved and normalized #1351

Merged
merged 4 commits into from Jun 25, 2020
Merged

Allow Windows unc paths to be resolved and normalized #1351

merged 4 commits into from Jun 25, 2020

Conversation

@TomWilloughby
Copy link
Contributor

@TomWilloughby TomWilloughby commented Jan 21, 2020

Fixes #1346

dcodeIO
dcodeIO approved these changes Feb 4, 2020
@alexander-fenster
Copy link
Contributor

@alexander-fenster alexander-fenster commented Jun 5, 2020

@TomWilloughby Can you please update the branch to the latest master to re-run the CI?

Loading

@TomWilloughby
Copy link
Contributor Author

@TomWilloughby TomWilloughby commented Jun 25, 2020

@alexander-fenster I've merged the latest master and made sure the CI passes. Sorry it took so long, I haven't been checking this account since lockdown started.

Loading

@alexander-fenster alexander-fenster merged commit cd4aeda into protobufjs:master Jun 25, 2020
9 checks passed
Loading
@alexander-fenster
Copy link
Contributor

@alexander-fenster alexander-fenster commented Jun 25, 2020

Thank you @TomWilloughby!

Loading

@TomWilloughby TomWilloughby deleted the windows-unc-path branch Jun 25, 2020
taylorcode added a commit to taylorcode/protobuf.js that referenced this issue Oct 16, 2020
…s#1351)

* Add unc paths to isAbsolute regex

* Allow unc paths to be resolved and normalized

* Remove trailing whitespace
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants