Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: properly parse empty messages in options #1429

Merged

Conversation

murgatroid99
Copy link
Contributor

@murgatroid99 murgatroid99 commented Jun 17, 2020

This fixes #1428.

@alexander-fenster alexander-fenster changed the title Properly parse empty messages in options fix: properly parse empty messages in options Jun 17, 2020
@alexander-fenster alexander-fenster merged commit 7fbc79f into protobufjs:master Jun 17, 2020
yangjuncode added a commit to yangjuncode/protobuf.js that referenced this pull request Jun 24, 2020
fix: properly parse empty messages in options (protobufjs#1429)
taylorcode pushed a commit to taylorcode/protobuf.js that referenced this pull request Oct 16, 2020
* Properly parse empty messages in options

* Add missing semicolon in test
This was referenced May 20, 2022
@github-actions github-actions bot mentioned this pull request Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Protobuf.js cannot parse fields with message values inside of custom field option messages
2 participants