Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make node detection a bit more forgiving #1445

Merged
merged 3 commits into from Jul 15, 2020
Merged

Conversation

@dcodeIO
Copy link
Member

@dcodeIO dcodeIO commented Jul 14, 2020

A follow-up to #1441, specifically #1441 (comment), that makes the node.js check a bit more forgiving in case the global object has been augmented.

Fixes #1443, fixes #1444

jhowr
jhowr approved these changes Jul 15, 2020
@dcodeIO dcodeIO requested a review from alexander-fenster Jul 15, 2020
@alexander-fenster alexander-fenster changed the title Make node detection a bit more forgiving fix: make node detection a bit more forgiving Jul 15, 2020
@alexander-fenster alexander-fenster merged commit 4e75f6d into master Jul 15, 2020
9 checks passed
Loading
@alexander-fenster alexander-fenster deleted the fix-global2 branch Jul 15, 2020
taylorcode added a commit to taylorcode/protobuf.js that referenced this issue Oct 16, 2020
* Make node detection a bit more forgiving

* reorder

* make sure we get a boolean
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants