Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add --no-service option for pbjs static target #1577

Merged
merged 2 commits into from Apr 14, 2021

Conversation

mdouglass
Copy link
Contributor

@mdouglass mdouglass commented Apr 4, 2021

This option skips generation of service clients.

This option skips generation of service clients.
@mdouglass
Copy link
Contributor Author

mdouglass commented Apr 4, 2021

We do not use the service clients for our projects (we have our own generator for those). It would be nice to be able to skip generation of the service clients to a) remove bulk from the generated file (in our code ~10K lines) and to avoid the confusion around the name clash with our own generated services.

This PR adds a --no-service option to static/static-module. The default behavior for the option is false to ensure that it is backward-compatible with existing users of the library.

Thanks!

@mdouglass
Copy link
Contributor Author

mdouglass commented Apr 10, 2021

Thanks @alexander-fenster!

@alexander-fenster alexander-fenster merged commit d01394a into protobufjs:master Apr 14, 2021
9 checks passed
@alexander-fenster alexander-fenster changed the title Add --no-service option for pbjs static target feat: add --no-service option for pbjs static target Apr 14, 2021
alexander-fenster added a commit that referenced this issue Apr 29, 2021
This option skips generation of service clients.

Co-authored-by: Alexander Fenster <fenster@google.com>
alexander-fenster added a commit that referenced this issue Jul 7, 2022
* feat: proto3 optional support

* chore: pre-release v6.11.0-pre

* fix: rebuild

* fix: fromObject should not initialize oneof members (#1597)

* test: adding test for pbjs static code generation

* fix: fromObject should not initialize oneof members

* chore: release v6.11.0

* chore: rebuild

* feat: add --no-service option for pbjs static target (#1577)

This option skips generation of service clients.

Co-authored-by: Alexander Fenster <fenster@google.com>

* deps: set @types/node to >= (#1575)

* deps: set @types/node to star version

When using `protobuf.js` as a dependency in a project it is important
that `@types/node` package gets de-duped and has the same version as for
the rest of the modules in the project. Otherwise, typing conflicts
could happen as they do between v13 and v14 node types.

* fix: use @types/node >=13.7.0

* fix: use @types/node >=13.7.0

Co-authored-by: Alexander Fenster <fenster@google.com>
Co-authored-by: Alexander Fenster <github@fenster.name>

* chore: rebuild

* docs: update changelog

* fix: parse.js "parent.add(oneof)“ error (#1602)

Co-authored-by: xiaoweili <xiaoweili@tencent.com>

* chore: release v6.11.1

* fix(types): bring back Field.rule to .d.ts

* fix: rebuild type, release v6.11.2

* build: configure backports

* build: configure 6.x as default branch

* fix: do not let setProperty change the prototype (#1731)

* fix(deps): use eslint 8.x (#1728)

* build: run tests if ci label added (#1734)

* build: publish to main

* chore(6.x): release 6.11.3 (#1737)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Support parsing of complex options

* Use readValue to read the proto value and add better example

* Fix lint issues

* fix: rollback files

* Re-do parse logic to take arrays into account and make it simpler

Co-authored-by: Alexander Fenster <fenster@google.com>
Co-authored-by: Matthew Douglass <5410142+mdouglass@users.noreply.github.com>
Co-authored-by: Fedor Indutny <fedor.indutny@gmail.com>
Co-authored-by: Alexander Fenster <github@fenster.name>
Co-authored-by: leon <leon776@users.noreply.github.com>
Co-authored-by: xiaoweili <xiaoweili@tencent.com>
Co-authored-by: Benjamin Coe <bencoe@google.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants