Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: parse.js "parent.add(oneof)“ error #1602

merged 1 commit into from Apr 29, 2021


Copy link

@leon776 leon776 commented Apr 29, 2021

In parse.js line 391, case rule === "proto3_optional" will do "parent.add(oneof)". But namespace.js not compatible this type.

@alexander-fenster alexander-fenster changed the title fix parse.js "parent.add(oneof)“ error fix: parse.js "parent.add(oneof)“ error Apr 29, 2021
@alexander-fenster alexander-fenster merged commit ecd6a48 into protobufjs:6.11.0 Apr 29, 2021
alexander-fenster pushed a commit that referenced this pull request Apr 29, 2021
Co-authored-by: xiaoweili <>
@leon776 leon776 deleted the 6.11.0 branch June 2, 2021 17:49
alexander-fenster added a commit that referenced this pull request Jul 7, 2022
* feat: proto3 optional support

* chore: pre-release v6.11.0-pre

* fix: rebuild

* fix: fromObject should not initialize oneof members (#1597)

* test: adding test for pbjs static code generation

* fix: fromObject should not initialize oneof members

* chore: release v6.11.0

* chore: rebuild

* feat: add --no-service option for pbjs static target (#1577)

This option skips generation of service clients.

Co-authored-by: Alexander Fenster <>

* deps: set @types/node to >= (#1575)

* deps: set @types/node to star version

When using `protobuf.js` as a dependency in a project it is important
that `@types/node` package gets de-duped and has the same version as for
the rest of the modules in the project. Otherwise, typing conflicts
could happen as they do between v13 and v14 node types.

* fix: use @types/node >=13.7.0

* fix: use @types/node >=13.7.0

Co-authored-by: Alexander Fenster <>
Co-authored-by: Alexander Fenster <>

* chore: rebuild

* docs: update changelog

* fix: parse.js "parent.add(oneof)“ error (#1602)

Co-authored-by: xiaoweili <>

* chore: release v6.11.1

* fix(types): bring back Field.rule to .d.ts

* fix: rebuild type, release v6.11.2

* build: configure backports

* build: configure 6.x as default branch

* fix: do not let setProperty change the prototype (#1731)

* fix(deps): use eslint 8.x (#1728)

* build: run tests if ci label added (#1734)

* build: publish to main

* chore(6.x): release 6.11.3 (#1737)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]>

* Support parsing of complex options

* Use readValue to read the proto value and add better example

* Fix lint issues

* fix: rollback files

* Re-do parse logic to take arrays into account and make it simpler

Co-authored-by: Alexander Fenster <>
Co-authored-by: Matthew Douglass <>
Co-authored-by: Fedor Indutny <>
Co-authored-by: Alexander Fenster <>
Co-authored-by: leon <>
Co-authored-by: xiaoweili <>
Co-authored-by: Benjamin Coe <>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants