Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: type names can be split into multiple tokens #1877

merged 1 commit into from
Mar 27, 2023


Copy link

Some proto packages are pretty long, and some proto formatters might split them into multiple lines in a weird way, like here:
      .LocationStringFilterType filter_type = 2;

The parser expects the whole type name to be just one token, and fails to parse this. I'm fixing the parser to accept multiple tokens as the type name: keep glueing tokens together while there are periods that separate parts of the type name.

Copy link
Contributor Author

Parser changes are scary, so if anyone from the community could review this, I would be grateful :) I will hold off merging for a day or two in hope someone else takes a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants