Mar ipns curriculum #188
Merged
Mar ipns curriculum #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrodriguez3313
added
IPFS
2color
reviewed
Aug 4, 2022
2color
reviewed
Aug 4, 2022
2color
reviewed
Aug 4, 2022
2color
reviewed
Aug 4, 2022
2color
reviewed
Aug 4, 2022
2color
reviewed
Aug 4, 2022
2color
reviewed
Aug 4, 2022
2color
reviewed
Aug 4, 2022
Co-authored-by: Daniel Norman <1992255+2color@users.noreply.github.com>
Co-authored-by: Daniel Norman <1992255+2color@users.noreply.github.com>
Co-authored-by: Daniel Norman <1992255+2color@users.noreply.github.com>
mrodriguez3313
reviewed
Aug 4, 2022
Included @2color 's suggestions. and added additional comments for review.
lidel
reviewed
Aug 5, 2022
|
Credits to @lidel @2color @TMoMoreau @TheDiscordian for the reviews |
2color
reviewed
Aug 10, 2022
2color
reviewed
Aug 10, 2022
2color
reviewed
Aug 10, 2022
2color
reviewed
Aug 10, 2022
2color
reviewed
Aug 10, 2022
2color
reviewed
Aug 10, 2022
2color
reviewed
Aug 10, 2022
2color
reviewed
Aug 10, 2022
2color
reviewed
Aug 10, 2022
2color
reviewed
Aug 10, 2022
|
|
||
| > Published to k51qzi5uqu5dkkciu33khkzbcmxtyhn376i1e83tya8kuy7z9euedzyr5nhoew: /ipfs/QmUVTKsrYJpaxUT7dr9FpKq6AoKHhEM7eG1ZHGL56haKLG | ||
| ``` | ||
| #### Common Pitfalls |
There was a problem hiding this comment.
@aschmahmann Can you please confirm these?
2color
reviewed
Aug 10, 2022
2color
reviewed
Aug 10, 2022
2color
reviewed
Aug 10, 2022
|
Awesome work @mrodriguez3313! I went the extra mile here to really nail this so that we can also port a lot of this work to the IPFS/IPNS docs. |
Co-authored-by: Daniel Norman <1992255+2color@users.noreply.github.com>
Co-authored-by: Daniel Norman <1992255+2color@users.noreply.github.com>
Awesome extension/addition to dnslink material Co-authored-by: Daniel Norman <1992255+2color@users.noreply.github.com>
Co-authored-by: Daniel Norman <1992255+2color@users.noreply.github.com>
Co-authored-by: Daniel Norman <1992255+2color@users.noreply.github.com>
Co-authored-by: Daniel Norman <1992255+2color@users.noreply.github.com>
|
@2color @lidel I think this is really good so far. I am super eager to push this and also having it later posted on docs ipfs page. This will be published to Gitbook automatically, but since we are moving to https://curriculum.pl-launchpad.io/ I will have to push to that branch as well when this is finalized. Any last suggestions or concerns? |
|
Let's merge it! I think this is great. |
2color
approved these changes
Aug 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This work is to follow details layed out in issue #162 for adding IPNS curriculum into Launchpad.