Skip to content
Permalink
Branch: master
Commits on Nov 14, 2019
  1. testing/protocmp: add Ignore options and Any support

    dsnet committed Oct 31, 2019
    This CL adds the following helper options:
    	func IgnoreEnums(...protoreflect.Enum) cmp.Option
    	func IgnoreMessages(...proto.Message) cmp.Option
    	func IgnoreFields(proto.Message, ...protoreflect.Name) cmp.Option
    	func IgnoreOneofs(proto.Message, ...protoreflect.Name) cmp.Option
    	func IgnoreDescriptors(...protoreflect.Descriptor) cmp.Option
    	func IgnoreDefaultScalars() cmp.Option
    	func IgnoreEmptyMessages() cmp.Option
    	func IgnoreUnknown() cmp.Option
    
    It also augments transformMessage to unmarshal and expand Any messages
    with the value of the underlying message. At this moment in time
    we do not provide an API to provide a custom type resolver.
    
    Change-Id: I51e1d9ff0d56d71161e510f366a7dcc32236d760
    Reviewed-on: https://go-review.googlesource.com/c/protobuf/+/204577
    Reviewed-by: Damien Neil <dneil@google.com>
Commits on Nov 13, 2019
  1. testing/protocmp: switch Enum.Number to be a method

    dsnet committed Nov 13, 2019
    Accessing Number as a method, rather than a field paves the
    way to have Enum potentially implement protoreflect.Enum
    in the future.
    
    Change-Id: Iebe9c0ec12e067decf2121d12fe2fb1549477b32
    Reviewed-on: https://go-review.googlesource.com/c/protobuf/+/207077
    Reviewed-by: Damien Neil <dneil@google.com>
  2. internal/impl: refactor makeStructInfo

    dsnet committed Nov 13, 2019
    Simplify the implementation of makeStructInfo by checking the
    names of the internal fields in a switch statement.
    Also, add "weakFields" as the unexported name for weak fields
    in preparation for actually unexporting it.
    
    Change-Id: Ide970a39e9caa5a24bc288ba3e3a0d223a6bfcb6
    Reviewed-on: https://go-review.googlesource.com/c/protobuf/+/207057
    Reviewed-by: Damien Neil <dneil@google.com>
You can’t perform that action at this time.