Permalink
Browse files

Remove unhelpful build warnings

-Wno-writable-strings removes 230 "ISO C++11 does not allow conversion from
string literal to 'char *'" warnings from TensorFlow test / build output.
These happen because pyext/ sources pass string literals to Python C API data
structures, e.g. PyGetSetDef, which for some reason were designed to not have
the const qualifier.
  • Loading branch information...
jart committed Nov 18, 2017
1 parent baed06e commit ac5371d13ed9dd3d19517e9008984f864af7cebf
Showing with 2 additions and 0 deletions.
  1. +2 −0 BUILD
View
2 BUILD
@@ -24,6 +24,8 @@ COPTS = select({
"-Woverloaded-virtual",
"-Wno-sign-compare",
"-Wno-unused-function",
# Prevents ISO C++ const string assignment warnings for pyext sources.
"-Wno-writable-strings",
],
})

0 comments on commit ac5371d

Please sign in to comment.