New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any plans to modularize (or add Automatic-Module-Name properties to) protobuf-java? #3903

Open
io7m opened this Issue Nov 16, 2017 · 1 comment

Comments

Projects
None yet
3 participants
@io7m

io7m commented Nov 16, 2017

Hello.

In order to play nicely with programs/libraries that have been modularized, it would be good if Automatic-Module-Name properties could be added to the protobuf-java jar files. This would give a stable name that can be used in the requires directives of modules.

http://blog.joda.org/2017/05/java-se-9-jpms-automatic-modules.html

Do not release to Maven Central a modular jar file that depends on an automatic module, unless the automatic module has an "Automatic-Module-Name" MANIFEST.MF entry.

I'd submit a PR, but I'm not sure what module names you'd want to use. Presumably something like com.google.protobuf.core and com.google.protobuf.lite.

@DJViking

This comment has been minimized.

DJViking commented Jun 2, 2018

This is a very much needed change. Currently google protobuf is the only dependency we use that still has not been modularized.

@xfxyjwf xfxyjwf added the P3 label Jun 11, 2018

@xfxyjwf xfxyjwf self-assigned this Jun 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment