Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conformance Test Failures for Objective-C #6863

Closed
rafi-kamal opened this issue Nov 8, 2019 · 5 comments · Fixed by #6866
Assignees

Comments

@rafi-kamal
Copy link
Contributor

@rafi-kamal rafi-kamal commented Nov 8, 2019

Down integration of Google3 changes (#6858) is breaking the Objective-C tests.

The broken tests have been added recently in cl/276783306. Should I add those to the failure list for now to move forward?

@thomasvl

This comment has been minimized.

Copy link
Contributor

@thomasvl thomasvl commented Nov 8, 2019

Go ahead and add them to the excludes, but keep this this open so I look at them.

@thomasvl

This comment has been minimized.

Copy link
Contributor

@thomasvl thomasvl commented Nov 8, 2019

I think I have a fix, but I'll wait for the PR to land so I can easily validate it.

thomasvl added a commit to thomasvl/protobuf that referenced this issue Nov 8, 2019
if the value was >32bit with the low bits all being zero, it was decoded as
false instead of as true.

Fixes protocolbuffers#6863
@thomasvl

This comment has been minimized.

Copy link
Contributor

@thomasvl thomasvl commented Nov 8, 2019

Patched your change in locally, fix is right, #6866 out for testing on kokoro.

@rafi-kamal

This comment has been minimized.

Copy link
Contributor Author

@rafi-kamal rafi-kamal commented Nov 8, 2019

Thank you!

thomasvl added a commit that referenced this issue Nov 8, 2019
if the value was >32bit with the low bits all being zero, it was decoded as
false instead of as true.

Fixes #6863
@thomasvl

This comment has been minimized.

Copy link
Contributor

@thomasvl thomasvl commented Nov 8, 2019

Landed the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.