Skip to content

Post alpha2 integrate - #225

Merged
liujisi merged 8 commits into
masterfrom
post-alpha2-integrate
Mar 4, 2015
Merged

Post alpha2 integrate#225
liujisi merged 8 commits into
masterfrom
post-alpha2-integrate

Conversation

@liujisi

@liujisi liujisi commented Mar 2, 2015

Copy link
Copy Markdown
Contributor

The first commit is generated by integration script; following commits are manual fixes. @cfallin @xfxyjwf @TeBoring for review.

- Maps for C++ lite
- C++ Arena optimizations.
- Java Lite runtime code size optimization.

Change-Id: I7537a4357c1cb385d23f9e8aa7ffdfeefe079f13
Change-Id: I23abcd7f5ad4a1c6b94b0035ac0441ea874cf55d
Change-Id: Iaa75f8333541bc378bea699e7f147c7f17b652ad
Change-Id: Idc5fb65a2cc469d55aff6f2cde0b51b326be0963
Change-Id: Ic0fdb52c17b9495c73b8ce15879531383a148585
The later is not supported by some versions of MSVC and the former is
more accurate for the use case.

Change-Id: I7096226b1ebfef8340d288bbaf2788540aa3e97f
class definition, which is a C++11 extension.

Change-Id: I477fe484d737f4c60c519d68f431940ffaa33431
@cfallin

cfallin commented Mar 2, 2015

Copy link
Copy Markdown
Contributor

LGTM, but maybe have @xfxyjwf or @TeBoring check over the maps changes too.

Change-Id: I97960f30d50b1635aa6c395377cd021ef5ebddd5
@TeBoring

TeBoring commented Mar 3, 2015

Copy link
Copy Markdown
Contributor

test for map lite is not merged intentionally. Do we need to merge it now?
Otherwise, LGTM

@liujisi

liujisi commented Mar 3, 2015

Copy link
Copy Markdown
Contributor Author

Last time I tried it's broken. I added a TODO for you. Feel free to work a fix and re-enable the tests.

@liujisi

liujisi commented Mar 4, 2015

Copy link
Copy Markdown
Contributor Author

I'll merge the PR for now. We can have another PR to add maps in master.

liujisi pushed a commit that referenced this pull request Mar 4, 2015
Post alpha2 integrate from google internal for C++ and Java
@liujisi
liujisi merged commit ed3c8a1 into master Mar 4, 2015
@liujisi
liujisi deleted the post-alpha2-integrate branch March 4, 2015 01:51
@liujisi
liujisi restored the post-alpha2-integrate branch February 16, 2016 23:35
@liujisi
liujisi deleted the post-alpha2-integrate branch May 10, 2016 21:28
@liujisi
liujisi restored the post-alpha2-integrate branch March 2, 2018 17:36
@xfxyjwf
xfxyjwf deleted the post-alpha2-integrate branch May 23, 2018 18:15
yordis pushed a commit to yordis/protobuf that referenced this pull request Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants