New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PHP descriptors #3391

Merged
merged 12 commits into from Aug 4, 2017

Conversation

Projects
None yet
5 participants
@michaelbausor
Contributor

michaelbausor commented Jul 18, 2017

@grpc-jenkins

This comment has been minimized.

Show comment
Hide comment
@grpc-jenkins

grpc-jenkins Jul 18, 2017

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

grpc-jenkins commented Jul 18, 2017

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

@grpc-jenkins

This comment has been minimized.

Show comment
Hide comment
@grpc-jenkins

grpc-jenkins Jul 18, 2017

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

grpc-jenkins commented Jul 18, 2017

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

@bazel-io

This comment has been minimized.

Show comment
Hide comment
@bazel-io

bazel-io Jul 18, 2017

Can one of the admins verify this patch?

bazel-io commented Jul 18, 2017

Can one of the admins verify this patch?

@googlebot googlebot added the cla: yes label Jul 18, 2017

@michaelbausor

This comment has been minimized.

Show comment
Hide comment
@michaelbausor

michaelbausor Jul 24, 2017

Contributor

@TeBoring Added PHP implementation of descriptors in Google\Protobuf namespace, PTAL

Contributor

michaelbausor commented Jul 24, 2017

@TeBoring Added PHP implementation of descriptors in Google\Protobuf namespace, PTAL

@TeBoring

This comment has been minimized.

Show comment
Hide comment
@TeBoring

TeBoring Jul 25, 2017

Contributor

ok to test

Contributor

TeBoring commented Jul 25, 2017

ok to test

@TeBoring

This comment has been minimized.

Show comment
Hide comment
@TeBoring

TeBoring Aug 2, 2017

Contributor

#3422 has been merged.

Contributor

TeBoring commented Aug 2, 2017

#3422 has been merged.

@TeBoring

This comment has been minimized.

Show comment
Hide comment
@TeBoring

TeBoring Aug 3, 2017

Contributor

It seems you need to add new file into Makefile.am

Contributor

TeBoring commented Aug 3, 2017

It seems you need to add new file into Makefile.am

@TeBoring

This comment has been minimized.

Show comment
Hide comment
@TeBoring

TeBoring Aug 4, 2017

Contributor

The error for jenkins is because the composer dependency used by jenkins is different after this change. Need to submit this change first and update the commit id in Dockerfile.

Contributor

TeBoring commented Aug 4, 2017

The error for jenkins is because the composer dependency used by jenkins is different after this change. Need to submit this change first and update the commit id in Dockerfile.

@michaelbausor michaelbausor changed the title from WIP: Update PHP descriptors to Update PHP descriptors Aug 4, 2017

@TeBoring TeBoring merged commit 21b0e55 into protocolbuffers:master Aug 4, 2017

3 of 5 checks passed

Jenkins Build finished.
Details
Jenkins 32bit Build finished.
Details
cla/google All necessary CLAs are signed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

TeBoring added a commit to TeBoring/protobuf that referenced this pull request Aug 4, 2017

TeBoring added a commit that referenced this pull request Aug 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment