Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up little endian int/long writes. #361

Merged
merged 1 commit into from Jun 6, 2015

Conversation

@brianduff
Copy link
Contributor

brianduff commented May 11, 2015

Change-Id: I303d712967f9885f7c3082d00f961f8ab93a6aed

Bug: 20636336
Change-Id: I303d712967f9885f7c3082d00f961f8ab93a6aed
@googlebot
Copy link

googlebot commented May 11, 2015

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.
@googlebot googlebot added the cla: no label May 11, 2015
@xfxyjwf
Copy link
Contributor

xfxyjwf commented Jun 6, 2015

LGTM

xfxyjwf added a commit that referenced this pull request Jun 6, 2015
Speed up little endian int/long writes.
@xfxyjwf xfxyjwf merged commit 3f9be70 into protocolbuffers:master Jun 6, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@xfxyjwf xfxyjwf added cla: yes and removed cla: no labels Jun 6, 2015
@xfxyjwf
Copy link
Contributor

xfxyjwf commented Jun 6, 2015

Labeled this as "cla:yes" because Brian is a Google employee.

@brianduff , googlebot doesn't recognize googlers automatically and you may want to just sign the CLA to avoid annoyance from googlebot.

@brianduff
Copy link
Contributor Author

brianduff commented Jun 6, 2015

The issue is because the googlebot doesn't check correctly for the CLA when
the committer is not the same as the pull requester. See http://b/20917233

On Sat, Jun 6, 2015 at 12:55 AM, Feng Xiao notifications@github.com wrote:

Labeled this as "cla:yes" because Brian is a Google employee.

@brianduff https://github.com/brianduff , googlebot doesn't recognize
googlers automatically and you may want to just sign the CLA to avoid
annoyance from googlebot.


Reply to this email directly or view it on GitHub
#361 (comment).

@pgrosu pgrosu mentioned this pull request Jul 28, 2016
lvht pushed a commit to lvht/protobuf that referenced this pull request Aug 1, 2018
…rshaler (protocolbuffers#361)


* Fix marshaling of Any containing object that implements JSONPBMarshaler.
* Add test for marshaling Any that implements JSONPBMarshaler.
* Add test for unmarshaling Any that implements JSONPBUnmarshaler.

Fixed issue protocolbuffers#360.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.