New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ruby segment fault #3708

Merged
merged 4 commits into from Oct 4, 2017

Conversation

Projects
None yet
5 participants
@TeBoring
Contributor

TeBoring commented Oct 2, 2017

  1. rb_ary_new cannot be called during allocate function. During allocate
    fucntion, the containing object hasn't been marked and rb_ary_new may
    invoke gc to collect containing object.
  2. The global map should be marked before allocating it. Otherwise it
    may be garbage collected.
Fix ruby segment fault
1) rb_ary_new cannot be called during allocate function. During allocate
fucntion, the containing object hasn't been marked and rb_ary_new may
invoke gc to collect containing object.
2) The global map should be marked before allocating it. Otherwise it
may be garbage collected.
@bazel-io

This comment has been minimized.

Show comment
Hide comment
@bazel-io

bazel-io Oct 2, 2017

Can one of the admins verify this patch?

bazel-io commented Oct 2, 2017

Can one of the admins verify this patch?

@googlebot googlebot added the cla: yes label Oct 2, 2017

@TeBoring TeBoring requested a review from haberman Oct 2, 2017

@TeBoring

This comment has been minimized.

Show comment
Hide comment
@TeBoring

TeBoring Oct 2, 2017

Contributor

Fix #3649

Contributor

TeBoring commented Oct 2, 2017

Fix #3649

TeBoring added some commits Oct 3, 2017

Show outdated Hide outdated ruby/Rakefile

@TeBoring TeBoring merged commit cd5f49d into protocolbuffers:master Oct 4, 2017

5 checks passed

Jenkins Build finished.
Details
Jenkins 32bit Build finished.
Details
cla/google All necessary CLAs are signed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@joshrose

This comment has been minimized.

Show comment
Hide comment
@joshrose

joshrose Oct 9, 2017

Thanks for this @TeBoring . Any idea when this will be published as part of a new release? Is there somewhere we can look to track what's happening with assembling future releases? Thanks.

joshrose commented Oct 9, 2017

Thanks for this @TeBoring . Any idea when this will be published as part of a new release? Is there somewhere we can look to track what's happening with assembling future releases? Thanks.

@TeBoring TeBoring referenced this pull request Oct 9, 2017

Closed

Ruby Segmentation Fault #3699

@TeBoring

This comment has been minimized.

Show comment
Hide comment
@TeBoring

TeBoring Oct 9, 2017

Contributor

We are working on 3.5.0 release. https://github.com/google/protobuf/milestone/21

Contributor

TeBoring commented Oct 9, 2017

We are working on 3.5.0 release. https://github.com/google/protobuf/milestone/21

@acozzette acozzette referenced this pull request Oct 26, 2017

Closed

Ruby Segmentation Fault #3788

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment