Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix iOS cc_library build for protobuf. #3757
The SDK and os versions were hard coded. Archs were mixed up.
Currently none of these are needed when using bazel with https://github.com/bazelbuild/rules_apple.
referenced this pull request
Oct 16, 2017
@pherl sorry, don't know enough about the state of the
cc_* rules (and crosstools) in opensourced bazel to say what is right. The current hardcoded values in there now aren't right in that it ties things to a specific Xcode release.
Since there doesn't seem to be anything currently in there for simulator builds, just removing the info will put device and simulator on the same basic setup.
From my understanding we don't need to distinguish between simulator and devices at the build file level. They are covered with defines like GOOGLE_PROTOBUF_ARCH_ARM and GOOGLE_PROTOBUF_ARCH_AARCH64 in google/protobuf/stubs/platform_macros.h in the sources. For example
Though I am a bit confused about _gcc when these are working fine with clang on linux/android and ios.