New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix php well known type conformance tests #3828

Merged
merged 7 commits into from Nov 3, 2017

Conversation

Projects
None yet
3 participants
@TeBoring
Contributor

TeBoring commented Nov 1, 2017

No description provided.

@googlebot googlebot added the cla: yes label Nov 1, 2017

@TeBoring TeBoring changed the title from Fix php well known type conformance tests [WIP] to Fix php well known type conformance tests Nov 3, 2017

@TeBoring TeBoring merged commit bcda919 into protocolbuffers:master Nov 3, 2017

20 of 23 checks passed

MacOS JRuby (Allowed Failure) Kokoro build finished
Details
MacOS Obj-C iOS Debug (Allowed Failure) Kokoro build finished
Details
MacOS Obj-C iOS Release (Allowed Failure) Kokoro build finished
Details
Jenkins Build finished.
Details
Jenkins 32bit Build finished.
Details
Linux C# Kokoro build finished
Details
Linux C++ Distcheck Kokoro build finished
Details
Linux Java Compatibility Kokoro build finished
Details
Linux Python Compatibility Kokoro build finished
Details
MacOS C++ Kokoro build finished
Details
MacOS C++ Distcheck Kokoro build finished
Details
MacOS JavaScript Kokoro build finished
Details
MacOS Obj-C CocoaPods Integration Kokoro build finished
Details
MacOS Obj-C OS X Kokoro build finished
Details
MacOS PHP5.6 Kokoro build finished
Details
MacOS PHP7.0 Kokoro build finished
Details
MacOS Python Kokoro build finished
Details
MacOS Python C++ (Allowed Failure) Kokoro build finished
Details
MacOS Ruby 2.1 Kokoro build finished
Details
MacOS Ruby 2.2 (Allowed Failure) Kokoro build finished
Details
cla/google All necessary CLAs are signed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

TeBoring added a commit to TeBoring/protobuf that referenced this pull request Nov 3, 2017

Fix php well known type conformance tests (protocolbuffers#3828)
* Fix php well known type conformance tests

* Properly generate code for test.proto

* Provide GPBMetadata files in c extensions for generated files to import.

* Remove unnecessary test

* Clean up code

* Add declaration for initOnce.

* Refactoring

TeBoring added a commit that referenced this pull request Nov 4, 2017

Fix php well known type conformance tests (#3828) (#3840)
* Fix php well known type conformance tests

* Properly generate code for test.proto

* Provide GPBMetadata files in c extensions for generated files to import.

* Remove unnecessary test

* Clean up code

* Add declaration for initOnce.

* Refactoring
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment