Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ValidateDateTime: check day instead month #4147

Merged
merged 1 commit into from Jan 8, 2018

Conversation

@datacompboy
Copy link
Contributor

commented Jan 5, 2018

Found with PVS-Studio static analyser, see
https://www.viva64.com/en/b/0550/

Found with PVS-Studio static analyser, see 
https://www.viva64.com/en/b/0550/
@grpc-kokoro

This comment has been minimized.

Copy link

commented Jan 5, 2018

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

1 similar comment
@grpc-kokoro

This comment has been minimized.

Copy link

commented Jan 5, 2018

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

@googlebot googlebot added the cla: yes label Jan 5, 2018
@acozzette

This comment has been minimized.

Copy link
Contributor

commented Jan 5, 2018

ok to test (this comment will trigger the other test runs)

@acozzette acozzette merged commit d4afdba into protocolbuffers:master Jan 8, 2018
5 checks passed
5 checks passed
Jenkins Build finished.
Details
Jenkins 32bit Build finished.
Details
cla/google All necessary CLAs are signed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@datacompboy datacompboy deleted the datacompboy:patch-1 branch Jan 9, 2018
@xfxyjwf xfxyjwf added the c++ label Jun 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.